Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offset column role in Task #1225

Merged
merged 34 commits into from
Feb 11, 2025
Merged

feat: offset column role in Task #1225

merged 34 commits into from
Feb 11, 2025

Conversation

bblodfon
Copy link
Contributor

@bblodfon bblodfon commented Dec 4, 2024 •
edited
Loading

  • Properly support offset for mlr3 learners
    • Some TODOs left (talked with Marc)
  • xgboost in mlr3learners uses this now mlr3learners PR
  • See mlr3proba PR for the PEM reduction pipeline (surv => regr) that uses this

@bblodfon bblodfon requested a review from be-marc December 4, 2024 16:31
@be-marc be-marc changed the title Add offset col_role in Task feat: offset column role in Task Jan 16, 2025
@bblodfon bblodfon mentioned this pull request Jan 21, 2025
Closed
sebffischer
sebffischer reviewed Jan 24, 2025
View reviewed changes
be-marc
be-marc reviewed Feb 6, 2025
View reviewed changes
be-marc
be-marc reviewed Feb 6, 2025
View reviewed changes
mb706
mb706 reviewed Feb 6, 2025
View reviewed changes
be-marc
be-marc reviewed Feb 6, 2025
View reviewed changes
be-marc
be-marc reviewed Feb 10, 2025
View reviewed changes
@be-marc be-marc merged commit 2375597 into main Feb 11, 2025
3 checks passed
@be-marc be-marc deleted the add_offset branch February 11, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mb706 mb706 mb706 left review comments

@sebffischer sebffischer sebffischer left review comments

@be-marc be-marc be-marc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bblodfon @mb706 @sebffischer @be-marc